Opened 3 years ago

Closed 3 years ago

#10 closed defect (fixed)

NullPointer in CellMLDiffInterpreter

Reported by: martin Owned by: martin
Priority: critical Milestone:
Component: code Version:
Keywords: Cc: martin

Description

there was a null pointer (see bivesws-client:#1) comparing:

and requesting report in HTML.

12.02 14:18:01 ERROR de.unirostock.sems.bives.webservice.Query@118: post request processing threw an error (throwing java.lang.NullPointerException: null)
        java.lang.NullPointerException: null
                at de.unirostock.sems.bives.algorithm.cellml.CellMLDiffInterpreter.checkComponents(CellMLDiffInterpreter.java:180)
                at de.unirostock.sems.bives.algorithm.cellml.CellMLDiffInterpreter.interprete(CellMLDiffInterpreter.java:107)
                at de.unirostock.sems.bives.api.CellMLDiff.getHTMLReport(CellMLDiff.java:154)
                at de.unirostock.sems.bives.Executer.executeCompare(Executer.java:307)
                at de.unirostock.sems.bives.webservice.WebQueryExecuter.executeQuery(WebQueryExecuter.java:113)
                at de.unirostock.sems.bives.webservice.Query.doPost(Query.java:114)
                at javax.servlet.http.HttpServlet.service(HttpServlet.java:641)
                at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
                at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
                at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
                at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:225)
                at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)
                at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472)
                at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:168)
                at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:98)
                at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:927)
                at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
                at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407)
                at org.apache.coyote.ajp.AjpProcessor.process(AjpProcessor.java:200)
                at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:579)
                at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:310)
                at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
                at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
                at java.lang.Thread.run(Thread.java:722)

unfortunately this version of the web service was build against a quite old version of bives, does this null pointer still exist? i guess at least not in this line...

Change History (1)

comment:1 Changed 3 years ago by Martin Scharm <martin@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 27a795aac6efdfe4b6253a8337a516d53aaaac9f:

added some test cases, fixed bug [fixes #10]

  • problem in #10 was a null pointer if there are no units defined in a component _AND_ this component wasn't mapped. (thus our previous tests didn't fail)
Note: See TracTickets for help on using tickets.
authorship